Use svg icons only for the toolbar icons #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainCorlay
approved these changes
Apr 18, 2025
trungleduc
requested changes
Apr 18, 2025
HaudinFlorence
force-pushed
the
replace_font_awesome_icons_by_svg_icons_in_the_toolbar
branch
from
95deff4 to
9aa88e0
Compare
Thanks for the comment @trungleduc. Unused import of terminalToolbarIcon has been removed. |
HaudinFlorence
force-pushed
the
replace_font_awesome_icons_by_svg_icons_in_the_toolbar
branch
from
edbb35d to
e295432
Compare
for more information, see https://pre-commit.ci
|
Integration tests report: appsharing.space |
|
Preview PR at appsharing.space |
trungleduc
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the pencil, the camera and the terminal console by svg icon with the
jp-icon3 style.