Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New issue labels #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GeorgianaElena
Copy link
Member

This adds some extra labels on new issues that use the issue templates:

  • needs: triage for bug reports
  • needs: discussion for feature requests

This PR also adds a new issue template, for problems that might not be super clear for the contributor if they happen because of a bug, a misconfiguration (and should be on Discourse) or just because of a missing feature.

I'm not sure at all if this is the way to go, but I think it might be a step towards implementing a more effective labeling system, that's sustainable and not based only on the bug-enhancement distinction, as @minrk nicely explained here.

Copy link
Member

@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's see if it helps people separate "bug" and "unsure/maybe broken" issues.

I share Min's experience that tagging is super hard to do consistently and once it isn't done rigorously it becomes not useful. I tend to go with "if it is important it will keep coming up" so issues/bugs that aren't on the front page https://github.com/jupyterhub/repo2docker/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc (this is the default view I have for all issues, also use it for PRs) aren't important enough. This means I am +-0 about adding (or not) the new tags.

@choldgraf
Copy link
Member

I agree w/ @betatim - I think the question is whether people will reliably remove that tag when an issue no longer needs discussion or triage. If the answer is "yes" then I think this would be useful. But if we suspect that people won't ever touch those tags then I worry it'll be a noisy signal since it won't actually convey any information about the status of the issue. So if we add labels like that I'd want to get some agreement for the team that we'll all start using them, or else the burden will likely fall on one or two people to keep them up to date.

On the extra issue template I am 👍 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants