Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completer plugin #49

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Completer plugin #49

merged 2 commits into from
Mar 3, 2025

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Feb 28, 2025

This PR add a new plugin for the completion provider, for more consistency with the chat plugin.

Before, the completion provider was embedded in the AIProvider, whereas the chat was instantiated in a plugin, and was listening for changes in the AIProvider.

Now, the completion provider is also instantiating in a plugin, and is also listening for change in the AIProvider.
This add more flexibility to disable one of the chat or completer.

It also rename some attributes/function in the AIProvider, from model to provider to avoid confusion with the model name of each LLM provider.

@brichet brichet added the enhancement New feature or request label Feb 28, 2025
@brichet brichet requested a review from jtpio February 28, 2025 17:53
@brichet
Copy link
Collaborator Author

brichet commented Feb 28, 2025

This is a first step related to #45.
With AIProvider only used to provide the current completer and chat provider, it will be easier to switch to a registry.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 336fb46 into jupyterlite:main Mar 3, 2025
8 of 9 checks passed
@brichet brichet deleted the completer_plugin branch March 3, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants