feat(router): Add support for retries with clear pan and network token payment method data #6905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasunna09
added
A-core
hyperswitch-bot
bot
added
the
M-database-changes
hyperswitch-bot
bot
added
the
M-api-contract-changes
jarnura
approved these changes
Jan 2, 2025
| { | ||
| match self { | ||
| Ok(a) => a, | ||
| Err(_) => func().await, |
There was a problem hiding this comment.
We should not be ignoring the error here
| @@ -59,6 +59,7 @@ pub struct Profile { | |||
| pub max_auto_retries_enabled: Option<i16>, | |||
| pub is_click_to_pay_enabled: bool, | |||
| pub authentication_product_ids: Option<serde_json::Value>, | |||
| pub is_clear_pan_retries_enabled: Option<bool>, | |||
There was a problem hiding this comment.
Suggested change
| pub is_clear_pan_retries_enabled: Option<bool>, | |
| pub is_clear_pan_retries_enabled: bool, |
|
|
||
| #[derive(Clone, serde::Serialize, Debug)] | ||
| pub enum VaultData { | ||
| CardVaultData(hyperswitch_domain_models::payment_method_data::Card), |
There was a problem hiding this comment.
nit: naming consistency
pub enum VaultData {
Card(),
NetworkToken(),
CardAndNetworkToken()
}
| @@ -4432,6 +4441,47 @@ where | |||
| pub tax_data: Option<TaxData>, | |||
| pub session_id: Option<String>, | |||
| pub service_details: Option<api_models::payments::CtpServiceDetails>, | |||
| pub vault_operation: Option<PaymentMethodDataAction>, | |||
There was a problem hiding this comment.
why is the field called vault_operation where the struct says PaymentMethodDataAction?
| @@ -1904,12 +1904,93 @@ pub async fn retrieve_card_with_permanent_token( | |||
| todo!() | |||
| } | |||
|
|
|||
| pub enum VaultFetchAction { | |||
| FetchCardDetailsFromLocker, | |||
| FetchCardDetailsForNetworkTransactionFlowFromLocker, | |||
There was a problem hiding this comment.
nit:
Suggested change
| FetchCardDetailsForNetworkTransactionFlowFromLocker, | |
| FetchCardDetailsForNetworkTransactionIdFlowFromLocker, |
| @@ -140,7 +142,22 @@ where | |||
| break; | |||
| } | |||
|
|
|||
| let connector = super::get_connector_data(&mut connectors)?; | |||
| let is_network_token = matches!( | |||
There was a problem hiding this comment.
This can be a impl based fn on PaymentMethodData
| .unwrap_or(false) | ||
| && business_profile.is_clear_pan_retries_enabled; | ||
|
|
||
| let connector = if should_retry_with_pan { |
There was a problem hiding this comment.
Please add relevant code comments here
| && business_profile.is_clear_pan_retries_enabled; | ||
|
|
||
| let connector = if should_retry_with_pan { | ||
| original_connector_data.clone() |
There was a problem hiding this comment.
Is clone required here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add support to retry a transaction with clear PAN or Network Token
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy