Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix toml format to address wasm build failure #6967

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

chore: fix toml format to address wasm build failure #6967

wants to merge 14 commits into from

Conversation

JeevaRamu0104
Copy link
Contributor

@JeevaRamu0104 JeevaRamu0104 commented Jan 2, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

An incorrect TOML format has been added to the ctp_mastercard due to which the wasm build is getting failed.

Add development as feature in wasm config

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@JeevaRamu0104 JeevaRamu0104 requested review from a team as code owners January 2, 2025 09:21
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@JeevaRamu0104 JeevaRamu0104 self-assigned this Jan 2, 2025
@JeevaRamu0104 JeevaRamu0104 added the A-euclid-foc Area: Euclid Family of Crates label Jan 2, 2025
@JeevaRamu0104 JeevaRamu0104 linked an issue Jan 6, 2025 that may be closed by this pull request
[CHORE]: wasm build fix juspay/hyperswitch-control-center#2014
Open
@pixincreate pixincreate changed the title chore: wasm jenkins build chore: fix toml format to address wasm build failure Jan 6, 2025
swangi-kumari
swangi-kumari previously approved these changes Jan 6, 2025
View reviewed changes
@JeevaRamu0104 JeevaRamu0104 requested a review from a team as a code owner January 6, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@swangi-kumari swangi-kumari Awaiting requested review from swangi-kumari

At least 2 approving reviews are required to merge this pull request.

Assignees

@JeevaRamu0104 JeevaRamu0104

Labels
A-euclid-foc Area: Euclid Family of Crates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CHORE]: wasm build fix
4 participants
@JeevaRamu0104 @SanchithHegde @sai-harsha-vardhan @swangi-kumari