chore(keymanager): add tenant-id to keymanager requests

[dracarys18]

Type of Change

• Enhancement

Description

Adds tenant-id for every requests to keymanager

Motivation and Context

Added tenant id header for the keymanager service to classify key ids based on tenants.

How did you test it?

• Create Merchant Account with x-tenant-id as public

curl --location 'http://localhost:8080/accounts' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'x-feature: integ-custom' \
--header 'x-tenant-id: public' \
--header 'api-key: test_admin' \
--data-raw '{
  "merchant_id": "1735815159",
  "locker_id": "m0010",
  "merchant_name": "NewAge Retailer",
  "merchant_details": {
    "primary_contact_person": "John Test",
    "primary_email": "[email protected]",
    "primary_phone": "sunt laborum",
    "secondary_contact_person": "John Test2",
    "secondary_email": "[email protected]",
    "secondary_phone": "cillum do dolor id",
    "website": "www.example.com",
    "about_business": "Online Retail with a wide selection of organic products for North America",
    "address": {
      "line1": "1467",
      "line2": "Harrison Street",
      "line3": "Harrison Street",
      "city": "San Fransico",
      "state": "California",
      "zip": "94122",
      "country": "US"
    }
  },
  "return_url": "https://google.com/success",
  "webhook_details": {
    "webhook_version": "1.0.1",
    "webhook_username": "ekart_retail",
    "webhook_password": "password_ekart@123",
    "payment_created_enabled": true,
    "payment_succeeded_enabled": true,
    "payment_failed_enabled": true
  },
  "sub_merchants_enabled": false,
  "metadata": {
    "city": "NY",
    "unit": "245"
  },
  "primary_business_details": [
    {
      "country": "US",
      "business": "default"
    }
  ]
}'

• Get the x-request-id for the request and query it in grafana and see the if the tenant_id is public
  

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/router/src/configs/settings.rs	27% smaller
crates/common_utils/src/keymanager.rs	1% smaller
config/development.toml	Unsupported file format
crates/common_utils/src/id_type/tenant.rs	0% smaller
crates/common_utils/src/types/keymanager.rs	0% smaller
crates/router/src/configs/defaults.rs	0% smaller
crates/router/src/types/domain/types.rs	0% smaller

[SanchithHegde]

I feel passing in empty string here could cause issues when this value is being serialized/deserialized.

@Narayanbhat166 Correct me if I'm wrong.

[dracarys18]

I believe the new_unchecked does not validate the length

[SanchithHegde]

But deserialization would. So, even if the application does start running with the empty string as the tenant ID, and say the tenant ID is serialized / deserialized when writing to / reading from Redis, then the serialization may go through but the deserialization would fail, thus possibly causing an internal server error.

[Narayanbhat166]

why can't we have the default tenant id as well? isn't it global?

[SanchithHegde]

Could you replicate similar changes in the other TOML config files which have global_tenant configuration?

[Narayanbhat166]

This function should not be public

[dracarys18]

We need this public to be used in router crate :/

[Narayanbhat166]

then we can create the function which will create the tenant id with specified name, we cannot accept any generic string for unchecked functions.

Reference:

hyperswitch/crates/common_utils/src/id_type/merchant.rs

Line 56 in 1f20a95

pub fn get_merchant_id_not_found() -> Self {

[dracarys18]

Okay