Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress): backup and restore sessions when using user apis #6978

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pixincreate
Copy link
Member

@pixincreate pixincreate commented Jan 2, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

this pr fixes the issue where cookies are not being set when hitting user apis.

  • we need to set cookies. but cypress does not directly support that
  • cy.setCookie() method does not persist outside of the it() block
  • in order to make it persist, we need to set session using cy.session() method in the beforeEach() hook

closes #6977

this pr, of course, does not fix the hooks (caching) issue.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

NA

How did you test it?

image

every failure here is related to assertion and globalState where connectorId and mcaId not getting updated. This can be picked up a separate PR since the fix done in this PR is P0

Checklist

  • I formatted the code npm run format && npm run lint -- --fix
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@pixincreate pixincreate added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 2, 2025
@pixincreate pixincreate added this to the December 2024 Release milestone Jan 2, 2025
@pixincreate pixincreate self-assigned this Jan 2, 2025
@pixincreate pixincreate requested a review from a team as a code owner January 2, 2025 15:58
Copy link

semanticdiff-com bot commented Jan 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG - Cypress] Cookie not passed in user APIs
2 participants