-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(dynamic_fields): Multiple SDK queries fixed #7380
Open
Sweta-Kumari-Sharma
wants to merge
3
commits into
main
Choose a base branch
from
dynamic-fields-adyen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+37
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
668ff2b
to
a55ec20
Compare
AkshayaFoiger
previously approved these changes
Mar 7, 2025
833bc30
to
40bc7c3
Compare
e0da7bb
to
8df617b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will force us to add county_code in the dynamic fields even when the connector doesn't require country_code as a mandatory field (rare scenarios)
1d6fbde
to
7723176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Multiple SDK queries fixed:
Additional Changes
Motivation and Context
https://github.com/juspay/hyperswitch-cloud/issues/8623
How did you test it?
Voucher payment
Response
Other refactoring is related to SDK and Dashboard WASM, so no need to test.
Checklist
cargo +nightly fmt --all
cargo clippy