feat(connector): [Hipay] Add Card Payments Flow #7475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepanshu-iiitu
changed the title
deepanshu-iiitu
requested changes
Mar 11, 2025
| _connectors: &Connectors, | ||
| ) -> CustomResult<RequestContent, errors::ConnectorError> { | ||
| let connector_req = transformers::HiPayTokenRequest::try_from(req)?; | ||
| router_env::logger::info!(raw_connector_request=?connector_req); |
There was a problem hiding this comment.
Remove this logger as it contains sensitive card info
| @@ -194,7 +307,10 @@ impl ConnectorIntegration<Authorize, PaymentsAuthorizeData, PaymentsResponseData | |||
|
|
|||
| let connector_router_data = hipay::HipayRouterData::from((amount, req)); | |||
| let connector_req = hipay::HipayPaymentsRequest::try_from(&connector_router_data)?; | |||
| Ok(RequestContent::Json(Box::new(connector_req))) | |||
| router_env::logger::info!(raw_connector_request=?connector_req); | |||
There was a problem hiding this comment.
Remove this logger
|
|
||
| let connector_router_data = hipay::HipayRouterData::from((capture_amount, req)); | ||
| let connector_req = hipay::HipayMaintenanceRequest::try_from(&connector_router_data)?; | ||
| router_env::logger::info!(raw_connector_request=?connector_req); |
There was a problem hiding this comment.
Remove this logger if not needed
| _connectors: &Connectors, | ||
| ) -> CustomResult<RequestContent, errors::ConnectorError> { | ||
| let connector_req = hipay::HipayMaintenanceRequest::try_from(req)?; | ||
| router_env::logger::info!(raw_connector_request=?connector_req); |
There was a problem hiding this comment.
Remove this logger if not needed
| let connector_req = hipay::HipayRefundRequest::try_from(&connector_router_data)?; | ||
| Ok(RequestContent::Json(Box::new(connector_req))) | ||
| let connector_req = hipay::HipayMaintenanceRequest::try_from(&connector_router_data)?; | ||
| router_env::logger::info!(raw_connector_request=?connector_req); |
There was a problem hiding this comment.
Remove this logger if not needed
| | HipayPaymentStatus::Refused | ||
| | HipayPaymentStatus::Expired | ||
| | HipayPaymentStatus::Denied => Self::Failure, | ||
| HipayPaymentStatus::AuthorizedAndPending => Self::Authorizing, |
There was a problem hiding this comment.
When do we get AuthorizedAndPending status?
| HipayPaymentStatus::AwaitingTerminal => Self::Pending, | ||
| HipayPaymentStatus::AuthorizationCancellationRequested => Self::VoidInitiated, | ||
| HipayPaymentStatus::ChallengeRequested => Self::AuthenticationPending, | ||
| HipayPaymentStatus::SoftDeclined => Self::AuthorizationFailed, |
There was a problem hiding this comment.
Mark this as Failure
| HipayPaymentStatus::Authenticated => Self::AuthenticationSuccessful, | ||
| HipayPaymentStatus::AcquirerNotFound => Self::Failure, | ||
| HipayPaymentStatus::RiskAccepted => Self::Pending, | ||
| HipayPaymentStatus::AuthorizationRefused => Self::AuthorizationFailed, |
There was a problem hiding this comment.
Mark this as Failure
Comment on lines
+524
to
+533
| #[derive(Debug, Deserialize, Serialize, PartialEq, Eq, Clone)] | ||
| #[serde(rename_all = "lowercase")] | ||
| pub enum HipaySyncState { | ||
| Completed, | ||
| Waiting, | ||
| Pending, | ||
| Declined, | ||
| Forwarding, | ||
| Error, | ||
| } |
There was a problem hiding this comment.
Where is this being used?
Comment on lines
+600
to
+603
| Ok(Self { | ||
| response, | ||
| ..item.data | ||
| }) |
There was a problem hiding this comment.
We should mark status as Failure here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added 3DS /No-3ds Card flows
Mandates Not added
Additional Changes
Motivation and Context
How did you test it?
Added Cypress Tests
Checklist
cargo +nightly fmt --allcargo clippy