Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat DISABLE_AUTOBUILD as number #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FluidSense
Copy link

!!"0" equals to true which does not feel correct when trying to disable the flag.
unset OPENCV4NODEJS_DISABLE_AUTOBUILD is the only way to disable it as it stands now.

@FluidSense
Copy link
Author

FluidSense commented Jun 30, 2020

Checks failing, I suspect these are not due to my change? If they are, please highlight how so I can try to fix it!

3397 passing (33s)
  52 pending
  3 failing
  1) cv
       OpenCV version should match:
      AssertionError: expected '' to equal '3.4.6'
      + expected - actual
      +3.4.6
      
      at Context.it (tests\index.test.js:80:64)
  2) cv
       io
         VideoCapture
           set
             should set properties:
      AssertionError: expected 1000 to equal 1001
      + expected - actual
      -1000
      +1001
      
      at Context.it (tests\io\VideoCaptureTests.js:53:50)
  3) cv
       io
         VideoCapture
           setAsync
             should set properties:
      Uncaught AssertionError: expected 1000 to equal 1001
      + expected - actual
      -1000
      +1001
      
      at cap.setAsync (tests\io\VideoCaptureTests.js:62:52)
npm ERR! code ELIFECYCLE
npm ERR! errno 3
npm ERR! [email protected] test-appveyor: `set APPVEYOR_BUILD=true && mocha --timeout 30000 ./tests/index.test.js`
npm ERR! Exit status 3
npm ERR! 
npm ERR! Failed at the [email protected] test-appveyor script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\appveyor\AppData\Roaming\npm-cache\_logs\20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant