-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Allow to add configuration per store (Multiple DSN...) #136
base: master
Are you sure you want to change the base?
Feature: Allow to add configuration per store (Multiple DSN...) #136
Conversation
…for current store due to a change in current store
While i like the idea, and LOVE the nitpick fixes 🚀 |
Hi @indykoning Thanks for your answer. This feature is only a new possibility that is not mandatory to use. |
Thank you so much for adding this PR @bruno-blackbird 👏 ! I've merged it alongside other improvements in my own fork. Much needed, and works perfectly! 🙏 THANK YOU! |
Summary
This pull request aims to add the ability to use distinct configuration per Magento Stores or Websites. We use it for a multi-website Magento where one Website is legacy and based on Luma and the Other one is based on Hyva theme.
As two different teams are working on the distinct websites, and to avoid merging issues between them, I needed to be able to customize the "dsn" and other configurations per website.
I also added the ability in the configuration to have the checkbox “can restore” on all config fields. So I can version a default configuration for each website on a config.xml file without blocking the ability to edit them through the configuration if needed.
An example of config.xml file :
The only element I kept in the env.php is the environment name (staging or production):