-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type information #82
base: master
Are you sure you want to change the base?
Conversation
@@ -11,6 +11,7 @@ | |||
# | |||
|
|||
# django | |||
from typing import Any, Dict, List, Tuple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Instance properties initialised in
__init__
are not typed - args and kwargs are untyped, so
__init__
needs to return -> None
Hello @justinmayer Do you want to integrate this or prefer a stub on typeshed (which I'm preparing now for local development)? |
@fabiommendes: Thank you for the pull request submission. My apologies for the delay in responding. Would you be so kind as to review the suggestions that @msopacua made and update your changes as appropriate? @msopacua: Many thanks for your sponsorship, which is deeply appreciated. And thank you for your assistance with reviewing this pull request. I think integrating the type information makes sense. ✨ |
@justinmayer You're very welcome. I've been using this library on and off since 2014 or so? So about time :) |
It's so cool to see confirmation that the library is still useful after all these years! Thank you for keeping it alive, @justinmayer :) |
This PR implements a minimal typing support to make Autoslug work with Mypy