Merge pull request #29 from jxsl13/chore/improve-recoverable-err-dete…

…ction

all unknown errors are recoverable

.github/workflows/test.yaml

@@ -1,3 +1,5 @@
+name: rabbitmq & toxiproxy integration tests
+
 on:
   push:
     branches: [ "main" ]
@@ -19,7 +21,10 @@ on:
       - 'go.mod'
       - 'go.sum'
 
-name: rabbitmq & toxiproxy integration tests
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
 jobs:
   test:
     strategy:
@@ -47,7 +52,7 @@ jobs:
 
     - name: Install govulncheck
       run: go install golang.org/x/vuln/cmd/govulncheck@latest
-    
+
     - name: Run govulncheck
       run: govulncheck ./...
 

pool/errors.go

@@ -2,7 +2,6 @@ package pool
 
 import (
 	"errors"
-	"net"
 
 	"github.com/rabbitmq/amqp091-go"
 )
@@ -38,14 +37,10 @@ func recoverable(err error) bool {
 		panic("checking nil error for recoverability")
 	}
 
-	oe := &net.OpError{}
-	if errors.As(err, &oe) {
-		return true
-	}
-
+	// invalid usage of the amqp protocol is not recoverable
 	ae := &amqp091.Error{}
 	switch {
-	case errors.As(err, &ae), errors.As(err, ae):
+	case errors.As(err, &ae):
 		switch ae.Code {
 		case notImplemented:
 			return false
@@ -62,5 +57,6 @@ func recoverable(err error) bool {
 		}
 	}
 
-	return errors.Is(err, amqp091.ErrClosed)
+	// every other unknown error is recoverable
+	return true
 }