Disable ConvertCurvesToArcs to avoid degenerate edge cases #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The edge case is described in #60. Hopefully this can re-land sometime soon, but it usually isn't the most significant optimization in play (and it is one of the trickiest!).
jzbrooks
commented
Aug 12, 2024
| @@ -235,7 +236,7 @@ class VectorDrawableCommandPrinter(private val decimalDigits: Int) : CommandPrin | |||
| private fun print(point: Point) = | |||
| buildString { | |||
| append(print(point.x)) | |||
| append(',') | |||
There was a problem hiding this comment.
I want to say there was a reason this was omitted only for vector drawables on first implementation. I vaguely remember there being some issues with framework implementations of vector drawable on android for SDK versions ~21 (avoided with compatibility lib).
I searched around the issue tracker and couldn't find evidence of this.
This prevents some vectors from being represented more verbosely than inputs, and it probably isn't an issue now in practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A temporary workaround for the edge case is described in #60.
Hopefully this can re-land sometime soon, but it usually isn't the most
significant optimization in play (and it is one of the trickiest!).