Implement ComposeArcMaps for 1-D arrays. #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpovey
reviewed
Apr 21, 2021
k2/csrc/fsa_utils.h
Outdated
| @@ -527,6 +527,21 @@ FsaVec FsaVecFromArcIndexes(FsaVec &fsas, Ragged<int32_t> &best_arc_indexes); | |||
| Ragged<int32_t> ComposeArcMaps(Ragged<int32_t> &step1_arc_map, | |||
| Ragged<int32_t> &step2_arc_map); | |||
|
|
|||
| /* | |||
| Compose arc maps from two successive FSA operations which give arc maps as | |||
| a 1-D array. | |||
There was a problem hiding this comment.
I notice the Index() function in array_ops.h is the same as this except it sets the value to 0 instead of -1.
How about adding an extra arg to that function that is the value to be used if the index is -1, defaulting to 0?
I prefer to use general-purpose operations.
csukuangfj
commented
Apr 23, 2021
| temp_storage->data, temp_storage_bytes, src_data, ans_data, n + 1, 0, | ||
| n, src_dim, c->GetCudaStream())); | ||
| } else { | ||
| // split the array and do a recursive call |
There was a problem hiding this comment.
Relates to NVIDIA/cub#288
|
You can merge this when it's convenient for you, looks OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to k2-fsa/snowfall#165
I am testing it in snowfall.