Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prompt written answers in custom language #1095

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

winggundamth
Copy link

πŸ“‘ Description

Changing language in the answer with default_prompt is not correct.

βœ… Checks

  • My pull request adheres to the code style of this project
  • All the tests have passed

Signed-off-by: Jirayut Nimsaeng (Dear) <[email protected]>
@winggundamth winggundamth requested review from a team as code owners May 4, 2024 21:31
@winggundamth winggundamth changed the title Fix prompt written answers in custom language fix: prompt written answers in custom language May 4, 2024
@AlexsJones
Copy link
Member

Thanks @winggundamth I am happy to change this, but I would say this is very dependent on the LLM being used. What was this tested with?

@winggundamth
Copy link
Author

winggundamth commented May 9, 2024

I'm testing with Meta-Llama, Phi, Mistral, and Gemma.

Screenshot 2567-05-09 at 16 46 27

@JuHyung-Son
Copy link
Contributor

does current language prompt not works on that models?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Proposed
Development

Successfully merging this pull request may close these issues.

4 participants