Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oci genai multi-model, serving mode #1223

Closed

Conversation

anders-swanson
Copy link
Contributor

@anders-swanson anders-swanson commented Aug 12, 2024

πŸ“‘ Description

Add support for OCI Llama APIs, and OCI dedicated AI clusters.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@anders-swanson anders-swanson requested review from a team as code owners August 12, 2024 14:19
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to provisionally approve the code, but can you please demonstrate the this working as I am unable to test? Also could you explain the changes, and why they are necessary?

@anders-swanson
Copy link
Contributor Author

Hi @AlexsJones, thanks for taking a look at the code, and apologies for any delay in my response.

This PR adds the following enhancements to the OCI provider:

  • Support the meta vendor of Llama family base LLM models, as previously only the cohere vendor family was supported.
  • Support OCI dedicated ai clusters, instead of just base models. This lets users wire up their fine-tuned OCI models with K8sgpt πŸ‘
  • Add the new topk parameter to the OCI provider.

Otherwise, the OCI provider works much the same as it did before:

% k8sgpt auth add -b oci -m <my model> -k <my compartment>

oci added to the AI backend provider list

% k8sgpt analyze --explain -b oci
... response from k8sgpt and oci model ...

@anders-swanson
Copy link
Contributor Author

@AlexsJones do you need additional information to finish your review?

@anders-swanson
Copy link
Contributor Author

@AlexsJones checking in here, is this PR still waiting for a review or is there something needed on my end?

@anders-swanson
Copy link
Contributor Author

closing in favor of fixing #1334

@anders-swanson
Copy link
Contributor Author

see #1337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants