Use GHCR docker image by default #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix daemonset, missing configmap
Eoghan1232
reviewed
Jun 11, 2024
| @@ -1,12 +1,12 @@ | |||
| FROM golang:alpine as builder | |||
| FROM docker.io/golang:alpine as builder | |||
There was a problem hiding this comment.
what's the reason behind this? I know we can do short hand and configure local container runtime.
I don't mind being more specific, just curious,
There was a problem hiding this comment.
In the general case, I think it's always better to be explicit about the container image source to ensure you get exactly the image you intend. In the case of Podman, by default it will throw an error about ambiguous image reference (it can be configured to do autocompletion).
Eoghan1232
approved these changes
Jun 11, 2024
|
@zeeke ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easer for users (rather than developers) to get started by making GHCR the default image source.
deployment/daemonset.yamlto reference GHCR rather than localhost