Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not read reconciler cron expression should be a warning #513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Oct 15, 2024

Changed from an error, since it returns a default value here, it shouldn't say it's an error, only warn that the file is not present.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer (optional):

@dougbtv dougbtv requested a review from maiqueb as a code owner October 15, 2024 19:13
@dougbtv dougbtv force-pushed the file-not-found-warning branch from 532585d to f080339 Compare October 15, 2024 19:21
Changed from an error, since it returns a default value here, it shouldn't say it's an error, only warn that the file is not present.
@dougbtv dougbtv force-pushed the file-not-found-warning branch from f080339 to 685506e Compare October 15, 2024 19:33
Copy link

Pull Request Test Coverage Report for Build 11353129277

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.58%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/reconciler/config.go 0 1 0.0%
Totals Coverage Status
Change from base Build 11241476772: 0.0%
Covered Lines: 1442
Relevant Lines: 2642

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants