Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #194

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Update documentation #194

merged 1 commit into from
Jun 26, 2024

Conversation

matthijsgroen
Copy link
Member

What

Explain what changes inside the code, this can be as simple or complicated as you want as long as it's clear

Why

Explain why these things are changes. This explanation is for your colleagues and your future self.

Code Review

Please consider the following checklist when reviewing this Pull Request.
More background and details here.

  • Does the code actually solve the problem it was meant to solve?
  • Is the code covered by unit tests? Integration tests?
  • Does anything here need documentation? (Focus on why, not what.)
  • Does any of this code deal with privacy sensitive information or affects security? Ask an additional reviewer.
  • Is the code easy to understand and change in the future?
  • Is the same code or concept duplicated? Find a balance between DRYness and readability.
  • Does the code reasonably adhere to the Kabisa coding standards?
  • Be kind.

@matthijsgroen matthijsgroen self-assigned this Jun 24, 2024
Copy link

codeclimate bot commented Jun 24, 2024

Code Climate has analyzed commit f4f5937 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 71.5% (0.0% change).

View more on Code Climate.

@matthijsgroen matthijsgroen merged commit da1d545 into develop Jun 26, 2024
6 checks passed
@matthijsgroen matthijsgroen deleted the fix/function-doc branch June 26, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant