feat(Dockerfile): allow to override kairos-init via build arg #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ettore Di Giacinto <[email protected]>
jimmykarily
reviewed
Feb 12, 2025
|
|
||
| FROM quay.io/kairos/kairos-init:v0.2.3 AS kairos-init | ||
| FROM quay.io/kairos/kairos-init:${KAIROS_INIT} AS kairos-init |
There was a problem hiding this comment.
Maybe it's better if we allow overriding the whole image? E.g. if we build one locally and push it to ttl.sh or something.
There was a problem hiding this comment.
will this work for renovate? Do we really need to do this on our Dockerfile? Do we expect to run it locally with a different init?
Just wondering why this would be wanted instead of a straightforward dockerfile. Doing local stuff is adding 3 lines so its not like its a very complex thing to create your own locally
There was a problem hiding this comment.
I rather indeed have the full address in kairos init var so renovate is able to bump it without having to start doing stupid regexes and custom managers again lol
jimmykarily
approved these changes
Feb 12, 2025
Itxaka
requested changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #