Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(feat): add middleware decorator and change validator trait #11

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

ikr4-m
Copy link
Contributor

@ikr4-m ikr4-m commented Mar 7, 2024

  • Changing Validator trait as Middleware because it's the same behind the scenes.
  • Casting all Promise<void> as MiddlewareHandler on Reflect because it is using the same traits as MiddlewareHandler. The function that using return Promise<void> on handler is for middleware that have next keyword.
  • Implementing and giving example how to use the decorator on HelloController.

@ikr4-m ikr4-m added the enhancement New feature or request label Mar 7, 2024
@ikr4-m ikr4-m requested review from Hazmi35, satoufuyuki and KagChi March 7, 2024 00:22
@ikr4-m ikr4-m self-assigned this Mar 7, 2024
Copy link

changeset-bot bot commented Mar 7, 2024

⚠️ No Changeset found

Latest commit: df45598

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ikr4-m ikr4-m merged commit 6839d75 into kakushindev:main Mar 7, 2024
1 check passed
Copy link

@Hazmi35 Hazmi35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants