This repository was archived by the owner on Jun 21, 2019. It is now read-only.
Set a timeout for http requests #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the SDK blocks and never returns if a server does not respond to a request. I had a situation in the wild while testing the login in my client, where this happened. And I have been able to simulate this behaviour with the new test case in this PR, see below.
To resolve this issue, I propose to introduce some timeout values as seen below. The current 2 second-delay is just a wild guess as to what I thought could be a practical value. I don't really know, which delay would be most sensible. The default implementation seems to never timeout. Some background information for the timeouts: http://www.baeldung.com/httpclient-timeout