OpenShift: Improve EFI code in sno-finish.sh #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use the same host to redeploy an OpenShift cluster we'll end up with a long list of RHCOS entries in EFI. With this patch we clean not only the DVD and CD entry but also any RHCOS entry previously created. This way only the newly RHCOS created entry will be left.
When cleaning EFI entries we are using:
```
efibootmgr -b 000$NUM -B $NUM
```
But according to the documentation the last $NUM is not necessary:
```
-b | --bootnum XXXX
Modify BootXXXX (hex).
-B | --delete-bootnum
Delete bootnum.
```
So we just remove it.
Current code in `sno-finish.sh` assumes there can never be more than 10 entries, which is not correct. If we've done a lot of retries deploying OpenShift on the same node we may have more than 10 EFI entries. With this patch we change the regex used to get the boot number as an hexadecimal 4 digits entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a couple of changes to the
sno-finish.shscript related to the EFI entries: