Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use box mirroring instead of fetching and parsing #372

Merged
merged 2 commits into from
Jul 24, 2021

Conversation

adityapurwa
Copy link
Collaborator

@adityapurwa adityapurwa commented Jul 24, 2021

Description

This PR contains changes that will remove the process of fetching and parsing data from WBW data sources and instead will use WBW Box as the source of data. This will greatly increase the speeds of CI/CD as now it only depends on the network speed only instead of including the complexities of parsing.

image

Current Tasks

N/A

@adityapurwa adityapurwa requested a review from zainfathoni July 24, 2021 09:50
@netlify
Copy link

netlify bot commented Jul 24, 2021

✔️ Deploy Preview for wargabantuwarga ready!

🔨 Explore the source changes: ee6a20a

🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/60fc09a2d956ea0008250db1

😎 Browse the preview: https://deploy-preview-372--wargabantuwarga.netlify.app

Copy link
Member

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Thanks for working on it @adityapurwa!
However, let's wait for Mas @mazipan's review as well to see his opinion about it.

@zainfathoni zainfathoni requested a review from mazipan July 24, 2021 11:00
@zainfathoni zainfathoni enabled auto-merge July 24, 2021 12:38
@zainfathoni
Copy link
Member

zainfathoni commented Jul 24, 2021

I'm enabling the auto-merge because the benefits of speeding up the build time outweigh the risks of getting failures from WBW Box. Speeding up the built time means faster GitHub Actions and Netlify builds.

@zainfathoni zainfathoni merged commit d8c9e50 into main Jul 24, 2021
@zainfathoni zainfathoni deleted the feature/use-box-for-data branch July 24, 2021 12:49
@mazipan
Copy link
Member

mazipan commented Jul 24, 2021

This is gold 🐐

@mazipan
Copy link
Member

mazipan commented Jul 24, 2021

Do you know the source of this https://wbw-box.lucentshard.com?
Who's generate this JSON?
Do we need to host on our side?
But it might be replaced by #374

@zainfathoni
Copy link
Member

It's using this exact repository, he hosted it on his own server. 😁
Here's the chat history to add some more context:

Screenshot 2021-07-24 at 22 27 53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants