Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpu_temp property to fritz status #232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

1RandomDev
Copy link

I added the cpu_temp property that returns an integer with the current CPU temperature and the call_http_query() method that lets you do custom requests to the query.lua endpoint.

@kbr
Copy link
Owner

kbr commented Nov 4, 2024

Thanks for your contribution, providing another URL for queries. At least by the interface-documentation from AVM this seems not to be covered. Do you have any references?

Then there are some issues (beside a minor PEP 8) with the code: in the FritzConnection class the aha-interface is owerwritten, the cpu-temperature is returned as string instead as a number and there is a lot of code-duplication.

From my point of view the integration of a third query-endpoint needs some refactoring in the existing code.

For future pull-requests I have created a new development-branch at github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants