refactor: Migrate to IntelliJ Platform Plugin #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use new IntellijPlatform syntax in build.gradle.kts - bump to lsp4ij:0.6.0 - bump to gradleVersion 8.10.0 Signed-off-by: rehan <[email protected]>
|
Do you have any documentation about sinceBuild and updateBuild or where did you refer to this migration? Previously we had in gradle.properties. It means supported build number ranges and IntelliJ Platform versions |
Signed-off-by: rehan <[email protected]>
Signed-off-by: rehan <[email protected]>
Signed-off-by: rehan <[email protected]>
He1pa
requested changes
Oct 12, 2024
Signed-off-by: rehan <[email protected]>
…gin' into migrate_to_Intellij_Platform_Plugin # Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
build.gradle.kts
gradle.properties
gradle/libs.versions.toml
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
I have tried migrating from gradle Intellij plugin (1.x) to newer IntelliJ platform Plugin. But as i am not good with gradle tasks, i hope someone can please look into that and help me point in the right direction.
We should also add gradle properties like sinceBuild and updateBuild i am not really sure about them.
I was also trying to add the new syntax for "runIdeForUiTest" task, but again i am not sure about that.
So yes this pr really needs a review from someone !.
Also can you please give it a "hacktoberfest-accepted" tag, it will help me complete the hacktober-fest challenge