Skip to content

Feature/fix sync action stdout redirect #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature/fix sync action stdout redirect #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76238d6
handle AttributeError when sys.stdout is redirected to None
Samuel-Havelka Feb 20, 2024
27eb7ac
Automated html docs build
Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions docs/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,11 @@ <h1 class="title">Module <code>keboola.component.base</code></h1>
if is_sync_action:
# sync action expects valid JSON in stdout on success.
result_str = process_sync_action_result(result)
sys.stdout.write(result_str)
# handle cases, when there is sync action called from another sync_action
try:
sys.stdout.write(result_str)
except AttributeError:
pass

return result

Expand Down Expand Up @@ -522,7 +526,11 @@ <h2 id="args">Args</h2>
if is_sync_action:
# sync action expects valid JSON in stdout on success.
result_str = process_sync_action_result(result)
sys.stdout.write(result_str)
# handle cases, when there is sync action called from another sync_action
try:
sys.stdout.write(result_str)
except AttributeError:
pass

return result

Expand Down
6 changes: 5 additions & 1 deletion src/keboola/component/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,11 @@ def action_wrapper(self, *args, **kwargs):
if is_sync_action:
# sync action expects valid JSON in stdout on success.
result_str = process_sync_action_result(result)
sys.stdout.write(result_str)
# handle cases, when there is sync action called from another sync_action
try:
sys.stdout.write(result_str)
except AttributeError:
pass

return result

Expand Down