Fix nats-jetstream scaler to use account ID instead of name

[cmay-zh]

NATS API uses account ID to filter by account (as confirmed by NATS team).

Current checks causes an issue when account ID and name are different. Updating the checks to use account ID instead.

To replicate issue, create a NATS account with name different from ID like below

  "account_details": [
    {
      "name": "platform",
      "id": "AABMFGXW62SSPMCCGFFOP7HFDFFBJWFAM3MC66OM2EHJDZS5CWTSHCWA",
      "memory": 0,
      "storage": 285,
      "reserved_memory": 0,
      "reserved_storage": 18446744073709551615,
      "accounts": 0,
      "ha_assets": 0,
      "api": {
        "total": 7088,
        "errors": 0
      },

Create nats-jetstream ScaledObject, check logs and find error “scaler”: “natsJetStreamScaler”, “error”: “leader node not found for consumer”

Checklist

• When introducing a new scaler, I agree with the scaling governance policy
• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been updated
• Changelog has been updated and is aligned with our changelog requirements
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on (repo) (if applicable)
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #

[JorTurFer]

Hello
I get your requirement, but this is a potential breaking change that we must avoid. Mi proposal is to add an extra parameter like 'accountID' to provide the value, and then use it to match account ID instead of account name. WDYT?
If this new parameter is mutually exclusive with the current account, it should work without any incident

[zroubalik]

Hello I get your requirement, but this is a potential breaking change that we must avoid. Mi proposal is to add an extra parameter like 'accountID' to provide the value, and then use it to match account ID instead of account name. WDYT? If this new parameter is mutually exclusive with the current account, it should work without any incident

💯

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.