-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
We want to simplify actions code generation to reduce build times and complexity. Solution recommended by GitHub documentation is using @vercel/ncc https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github We tried it before but for some reason the tool wasn't working well with our code, so we switched to babel. It turns out that the latest version of ncc is able to handle our code generation, hence we're switching to it. The change let us simplify also linting configuration to have just once config.
- Loading branch information
Showing
39 changed files
with
35,032 additions
and
10,553 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,2 @@ | ||
dist/ | ||
node-modules/ | ||
actions/notify-workflow-completed/node_modules/ | ||
actions/notify-workflow-completed/dist/ | ||
|
||
# Following directories have their own formatting configuration: | ||
actions/run-workflow/ | ||
actions/upstream-builds-query/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,5 +27,5 @@ branding: | |
icon: "rotate-ccw" | ||
|
||
runs: | ||
using: "node12" | ||
main: "dist/main.js" | ||
using: node16 | ||
main: "./dist/index.js" |
Oops, something went wrong.