-
Notifications
You must be signed in to change notification settings - Fork 979
fix: labels namespace filtering in rules not working #4670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4670 +/- ##
==========================================
- Coverage 46.69% 46.63% -0.07%
==========================================
Files 165 165
Lines 17005 17070 +65
==========================================
+ Hits 7940 7960 +20
- Misses 9065 9110 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…thub.com/keephq/keep into 4662-labels-namespace-filtering-in-rules
…e casting to use DataType
…orts in CorrelationTable
… remove unused IndexAccessNode
…oundBadge and related components
…thub.com/keephq/keep into 4662-labels-namespace-filtering-in-rules
…idebar and MonacoCelEditor
…node validation in PropertiesMapper
Signed-off-by: Ihor Panasiuk <[email protected]>
Signed-off-by: Ihor Panasiuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes #4662
📑 Description
MethodAccess
node to streamline the CEL AST structure.contains
,startswith
, andendswith
method nodes withComparisonNode
using appropriate operators.CelInput
component to support read-only mode for displaying rules in the Correlation Rules table.react-querybuilder/parseCEL
with a new approach that uses CEL AST JSON to construct theQueryBuilder
structure./alerts/search
endpoint with/alerts/query
for Correlation Rules.✅ Checks
ℹ Additional Information