fixed image nativearray deallocation when entry is set back to cold pool #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I'll consider merging it in future updates. |
hybridherbst
force-pushed
the
fix/asyncreadback-deallocation-optimization
branch
from
929ce39 to
e69e173
Compare
RichardTea
reviewed
Jan 2, 2025
| @@ -59,11 +62,21 @@ public Interop.FourCC FourCC | |||
|
|
|||
| public void Allocate(int width, int height, bool alpha, string metadata) | |||
| { | |||
| _lastUsedTime = DateTime.Now; | |||
There was a problem hiding this comment.
DateTime.Now is not monotonic, so should only be used for user-visible timestamps.
It can go backwards and often doesn't advance at 1 second per second.
Consider using Unity's Time.unscaledTime or Time.realtimeSinceStartup or System.Diagnostics.Stopwatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that each AsyncReadback Entry will be deallocated when it's moved back to the cold pool. Which results in unnecessary memory allocation and deallocation. So i made some changes which only results in recreation when the required nativearray length has changed.
I also added automatic deallocation for staled entries which are not used for more than 3 seconds for lower memory consumption. In case of unexptected app stuttering, interruptions and so on.