Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fix examples - proper publicPath do load dynamic lib imports #2795

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

igorDykhta
Copy link
Collaborator

@igorDykhta igorDykhta commented Nov 28, 2024

  • this issue was caused by dynamic module loading for map libs (introduced two months ago), but this issue appeared only with the attempted release.
  • bundle.js tried to import map-libre-gl from the wrong path.

PS: trigger release to update examples ?

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for keplergl2 ready!

Name Link
🔨 Latest commit 31285eb
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/6747ba6949a484000877eeab
😎 Deploy Preview https://deploy-preview-2795--keplergl2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lixun910
Copy link
Collaborator

Thanks, @igorDykhta! Just did a quick test: after click to load a sample map, the map was still not rendered (see the screenshot below)

keplergl-test

@igorDykhta
Copy link
Collaborator Author

@lixun910 All examples or just the one with arrow file?

@lixun910
Copy link
Collaborator

All examples, see the netlify deploy-preview: https://deploy-preview-2795--keplergl.netlify.app/

@igorDykhta
Copy link
Collaborator Author

I'll check what is wrong tomorrow in a separate PR

@igorDykhta igorDykhta merged commit f4f7fd2 into master Nov 28, 2024
12 checks passed
@igorDykhta igorDykhta deleted the igr/fix-examples-chunks-relative-path branch November 28, 2024 01:07
@lixun910
Copy link
Collaborator

Sounds good. Thank you! @igorDykhta

@igorDykhta
Copy link
Collaborator Author

The PR is deployed and looks like the examples are updated without a need for extra actions.
Not sure why the issue with the missing basemap appeared only yesterday, and not two months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants