-
Notifications
You must be signed in to change notification settings - Fork 215
Resolves [docs]: Add More Glossary Terms to Testing Glossary Page #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and congratulations 🎉 for opening your very first pull request in keploy
…ting. Signed-off-by: BillyDoesDev <[email protected]>
33c101a
to
39c4082
Compare
@nehagup Could you please review this PR when you have time? 🙏 |
hey @BillyDoesDev Thanks for raising this pr with observability testing and fixing the chore typo, can you please add a bit more of content in the observability page, you can try adding a few more images o diagrams to explain it. You can also write a bit more of content to explain the concept. |
Thank you so much for the feedback, @amaan-bhati! |
added an example for testing observability in a python app Signed-off-by: BillyDoesDev <[email protected]>
Hey, @amaan-bhati! I have made the observability page more verbose by explaining more on what it is and how it helps, and also including a simple python example to test it out. The rest of the content remains the same, highlighting how Keploy could help prevent potential issues in the first place, before even diving into observability logs and traces. |
Hey @BillyDoesDev Thanks for raising this pr and making the changes as requested, we'd love to take this forward and merge, can you please resolve the merge conflicts before we do so? |
Sure! I'll get it done shortly. |
Signed-off-by: BillyDoesDev <[email protected]>
@amaan-bhati, I have resolved the merge conflicts. Feel free to merge it whenever you get the time to! |
What has changed?
Fix broken link to Stubs in Glossary. Added "observability-testing" as a new Glossary item.
This PR Resolves #2770
Type of change
How Has This Been Tested?
The build has been tested using the docker-compose file provided.
The
dockerfile
starts the app via:Running the docker container with host

0.0.0.0
(so we expose the host machine as well), we get:Output gif:
Checklist: