Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

To support io.Bytesio #339

Merged
merged 7 commits into from
Feb 4, 2021
Merged

To support io.Bytesio #339

merged 7 commits into from
Feb 4, 2021

Conversation

TreeKat71
Copy link
Contributor

Summary

from keras_preprocessing import image 
image.load_img(**path**, target_size)

path can be io.Byteio before, but due to the fix in #261. It doesn't work anymore.
I also read issues #293 and #294 for compatibility. Please let me know if there is any concerns.

Related Issues

#261
#293
#294

PR Overview

  • [n] This PR requires new unit tests [y/n] (make sure tests are included)
  • [n] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • [y] This PR is backwards compatible [y/n]
  • [n] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

Copy link
Contributor

@Dref360 Dref360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

Please add unit tests for all cases.

@TreeKat71 TreeKat71 requested a review from Dref360 February 4, 2021 18:30
Copy link
Contributor

@Dref360 Dref360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dref360 Dref360 merged commit 6701f27 into keras-team:master Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants