Skip to content

Fix for issue #21118: inconsistent behavior across callbacks #21124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

adar21a
Copy link

@adar21a adar21a commented Apr 2, 2025

Copy link

google-cla bot commented Apr 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.69%. Comparing base (6d26efb) to head (acec574).

Files with missing lines Patch % Lines
keras/src/callbacks/model_checkpoint.py 80.00% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21124      +/-   ##
==========================================
- Coverage   82.69%   82.69%   -0.01%     
==========================================
  Files         564      564              
  Lines       54132    54152      +20     
  Branches     8411     8420       +9     
==========================================
+ Hits        44765    44779      +14     
- Misses       7294     7297       +3     
- Partials     2073     2076       +3     
Flag Coverage Δ
keras 82.50% <80.00%> (-0.01%) ⬇️
keras-jax 64.08% <80.00%> (+<0.01%) ⬆️
keras-numpy 59.08% <8.57%> (-0.02%) ⬇️
keras-openvino 32.87% <8.57%> (-0.01%) ⬇️
keras-tensorflow 64.36% <80.00%> (+<0.01%) ⬆️
keras-torch 64.12% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbaned gbaned added this to PR Queue Apr 3, 2025
@github-project-automation github-project-automation bot moved this to Assigned Reviewer in PR Queue Apr 3, 2025
@gbaned
Copy link
Collaborator

gbaned commented Apr 3, 2025

Hi @adar21a Can you please sign CLA? Thank you!

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please add a unit test for the fixed use cases.

@adar21a adar21a closed this May 11, 2025
@adar21a adar21a deleted the consistent-behavior-across-callbacks branch May 11, 2025 18:18
@github-project-automation github-project-automation bot moved this from Assigned Reviewer to Closed/Rejected in PR Queue May 11, 2025
@adar21a
Copy link
Author

adar21a commented May 11, 2025

Thanks for the PR! Please add a unit test for the fixed use cases.

Hi @fchollet :) I transitioned this PR to #21275 and I added there the unit test for this fixed case. Let me know if now it's OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed/Rejected
Development

Successfully merging this pull request may close these issues.

4 participants