Implementation np.moveaxis function #21269
Open
+17
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21269 +/- ##
=======================================
Coverage 82.57% 82.57%
=======================================
Files 564 564
Lines 54656 54670 +14
Branches 8496 8499 +3
=======================================
+ Hits 45131 45145 +14
Misses 7435 7435
Partials 2090 2090
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rkazants
reviewed
May 13, 2025
.gitignore
Outdated
| .ruff_cache | ||
| venv/ |
rkazants
reviewed
May 13, 2025
pytest.ini
Outdated
| @@ -0,0 +1,3 @@ | |||
| [pytest] | |||
There was a problem hiding this comment.
remove it. it is needed only for developer purpose
|
@fchollet, looks good to me. Recommend to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #30118
Follows the same pattern as other similar functions in the file
Passes all tests
I've removed the test from the excluded tests list, which allows for proper validation of the functionality.
@rkazants for review
All tests are passing: