Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for cash to be deposited or withdrawn during a backtest #925

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Allow for cash to be deposited or withdrawn during a backtest #925

wants to merge 2 commits into from

Conversation

AdiSai
Copy link

@AdiSai AdiSai commented Mar 2, 2023

No description provided.

@AdiSai AdiSai marked this pull request as draft March 2, 2023 05:26
@kernc
Copy link
Owner

kernc commented Apr 1, 2023

Sorry for the late turnaround. I'm not yet decided, but certainly not strongly opposed to this change. However, in the style of the rest of this library, I'd prefer Strategy.cash being a @property.

Implementing this would prevent people from accessing self._broker._cash as in #493, #340, #124, ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdiSai @kernc