-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore the "extend" field #6385
Comments
Hey, can I try work on this issue please? |
Hi sorry can you clarify, do you want the property extend ignored always or add an option to ignore it? Should the user have the option to add extend if it and any sub-properties are ignored? |
always ignored - it contains extra metadata that shouldn't be parsed in the editor |
I think it would be better to be filtered from the UI than having ad-hoc handling inside the Flow. This extend part will stay forever inside the flow YAML which is not a good idea. I even think it's a bad idea to mix flow YAML and blueprint specific YAML inside the same root, if at some point we want to have an So this flow:
id: flowId
namespace: flowNamespace
tasks: []
# all other blueprint information here
title: blueprint title
description: blueprint description |
We discussed this a long time ago and we decided against it. Blueprints must be useable as is without nesting it inside of some parent flow source property. Up to you if you prefer to filter the extent on the BE or FE side, the only requirements are:
|
You cannot sync a flow with extend as there is no such property. So I'll make the change on the BE, a flow YAML must not have this extend, it only clutter it as, as I said, if we didn't filter it before, it will stay forever in the source. |
Next steps: we discussed with Loic so he has all the context as to why this topic is important (we will be able to use many blueprints for QA directly) and Loic will coordinate the implementation with Florian and Brian |
@brian-mulier-p assigned to you, let us know if things are not clear (we had a meeting 2 weeks ago, and Loic has all the context). |
We discussed with @loicmathieu, and the |
What about Not a big fan of the |
@Ben8t We need @brian-mulier-p Extension management within a flow? What do you mean? Let's not use Reminder of what this is intended to be used for -- extra info about a blueprint: extend:
title: Trigger multiple Airbyte Cloud syncs in parallel, then run a dbt job
description: |
This flow runs Airbyte Cloud syncs in parallel and then runs dbt Core's CLI
commands.
It's recommended to configure the GCP service account and [Airbyte API
token](https://portal.airbyte.com/apiKeys), referenced in the
`pluginDefaults`, as a secret.
tags:
- Ingest
- Git
- dbt
- BigQuery
- Parallel
ee: false
demo: false
meta_description: "This flow runs Airbyte Cloud syncs in parallel and then runs
dbt Core's CLI commands. "
|
Feature description
We wanted to add backend handling to ignore the property "extend" and all its sub-properties so that flows could be deployed directly from blueprints. However, this is not the case yet.
The text was updated successfully, but these errors were encountered: