Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Recovered method in flow service for plugins #5571

Merged
merged 1 commit into from
Oct 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions core/src/main/java/io/kestra/core/services/FlowService.java
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,24 @@ public static String generateSource(Flow flow, @Nullable String source) {
return source;
}

// Used in Git plugin
public List<Flow> findByNamespacePrefix(String tenantId, String namespacePrefix) {
if (flowRepository.isEmpty()) {
throw noRepositoryException();
}

return flowRepository.get().findByNamespacePrefix(tenantId, namespacePrefix);
}

// Used in Git plugin
public FlowWithSource delete(FlowWithSource flow) {
if (flowRepository.isEmpty()) {
throw noRepositoryException();
}

return flowRepository.get().delete(flow);
}

@SneakyThrows
private static String toYamlWithoutDefault(Object object) throws JsonProcessingException {
String json = NON_DEFAULT_OBJECT_MAPPER.writeValueAsString(object);
Expand Down
14 changes: 14 additions & 0 deletions core/src/test/java/io/kestra/core/services/FlowServiceTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -296,4 +296,18 @@ void areAllowedAllNamespaces() {
void checkAllowedAllNamespaces() {
flowService.checkAllowedAllNamespaces("tenant", "fromTenant", "fromNamespace");
}

@Test
void delete() {
Flow flow = create("deleteTest", "test", 1);
FlowWithSource saved = flowRepository.create(flow, flow.generateSource(), flow);
flowService.delete(saved);
}

@Test
void findByNamespacePrefix() {
Flow flow = create("findByTest", "test", 1);
FlowWithSource saved = flowRepository.create(flow, flow.generateSource(), flow);
assertThat(flowService.findByNamespacePrefix(null, "io.kestra").size(), is(1));
}
}