Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix dev for arm64 & prettier #5574

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Oct 21, 2024

What changes are being made and why?

  • First, added a missing optional dependency to allow development on arm64 architectures (Apple SIlicon + New MS processors)
  • Second, I added a global .prettierignore file. Since we do not use prettier, but a lot of FE users might, we need to clarify this position and make sure that they don't re-format the code on every save.

@elevatebart elevatebart changed the title Elevatebart/fix-dev-for-arm64 build: fix dev for arm64 & prettier Oct 21, 2024
@elevatebart elevatebart marked this pull request as ready for review October 21, 2024 09:14
Copy link
Member

@MilosPaunovic MilosPaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@MilosPaunovic MilosPaunovic merged commit 5ada1a2 into develop Oct 21, 2024
2 checks passed
@MilosPaunovic MilosPaunovic deleted the elevatebart/fix-dev-for-arm64 branch October 21, 2024 09:20
Copy link

kratosmy pushed a commit to kratosmy/kestra that referenced this pull request Oct 23, 2024
* build: fix dev env for arm64

* add global prettierignore

---------

Co-authored-by: Bart Ledoux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants