Feature/2197 replay with input #2197 #5698
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamviqar
changed the title
Skraye
requested changes
Oct 29, 2024
webserver/src/main/java/io/kestra/webserver/controllers/api/ExecutionController.java
Outdated
Show resolved
Hide resolved
|
Thanks, @Skraye , for your review comments! I’ll address them as soon as possible. |
Co-authored-by: YannC <[email protected]>
|
@Skraye I've addressed most of your code review comments, except for the tests on the backend API. I marked this PR as a draft because there are still pending implementations for the backend API. I'm currently trying to determine how to pass the input values received as parameters in the execution controller to the actual execution. I noticed there aren't any setter methods for inputs in the execution object, and I would appreciate your assistance with this. Regards |
|
Hello @iamviqar, any update on this? |
|
Hi @iamviqar, are there any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are being made and why?
How the changes have been QAed?
Setup Instructions