Issue : https://github.com/kestra-io/kestra/issues/4574 Added a bulk delete option in backend #5949
+132
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Skraye please provide some advice on how to run this. |
|
Hii @MilosPaunovic , please go through the frontend once you get time . |
|
@yoyounik Kestra does not compile |
|
Hii @Skraye now i made the changes, all the check are running , please go through it |
Skraye
requested changes
Nov 18, 2024
| @@ -43,6 +44,9 @@ public class LogController { | |||
| @Inject | |||
| private TenantService tenantService; | |||
|
|
|||
| @Inject | |||
| private LogService a; | |||
There was a problem hiding this comment.
what should i name it then?
There was a problem hiding this comment.
logService named already exist with :
There was a problem hiding this comment.
the current logService should be renamed executionLogService, so your logService that use the class LogService can keep his name, so we know which class is used behind the variable name
…lete-option # Conflicts: # core/src/main/java/io/kestra/core/services/LogService.java # webserver/src/main/java/io/kestra/webserver/controllers/api/LogController.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lk delete option.
I have added the Java Backend code, for bulk deletion.
This is PR to the issue no. : #4574
What changes are being made and why?
How the changes have been QAed?
Setup Instructions