fix(core): properties as map is now working properly with expression within base maps #6800
+50
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicmathieu
requested changes
Jan 16, 2025
| try { | ||
| property.value = MAPPER.readValue(rendered, type); | ||
| if (property.expression.startsWith("{{")) { |
There was a problem hiding this comment.
An expression can be "in the middle" so it would be better to check if it contains {{ and }}.
We should have an helper for that as I think it's already done somewhere else
There was a problem hiding this comment.
And I'm not sure I understand why you did this...
There was a problem hiding this comment.
Because there's two cases for which you would want to render as map (obviously when the target property type is a map):
- the property itself is an expression ({{outputs.task.myMap}})
- the property is filled with a yaml map (which can itself contain expression for each value that's why checking for "contains {{" is not enough
There was a problem hiding this comment.
You should at least check for start and end.
And please add a comment as it's not trivial to understand reading the code
core/src/test/java/io/kestra/core/models/property/DynamicPropertyExampleTask.java
Show resolved
Hide resolved
|
brian-mulier-p
force-pushed
the
fix/property-as-map-with-nested-expressions
branch
from
ee648c6 to
dd04042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.