Apply suggestions from code review

build.gradle

@@ -102,7 +102,6 @@ dependencies {
     // test deps needed only for to have a runner
     testAnnotationProcessor group: "io.kestra", name: "processor", version: kestraVersion
     testImplementation group: "io.kestra", name: "core", version: kestraVersion
-    testImplementation group: "io.kestra", name: "core", version: kestraVersion, classifier: "tests"
     testImplementation group: "io.kestra", name: "repository-memory", version: kestraVersion
     testImplementation group: "io.kestra", name: "runner-memory", version: kestraVersion
     testImplementation group: "io.kestra", name: "storage-local", version: kestraVersion
@@ -120,8 +119,6 @@ dependencies {
     testImplementation "org.testcontainers:minio:1.19.8"
     testImplementation "org.testcontainers:localstack:1.19.8"
 
-    testImplementation 'io.minio:minio:8.5.10'
-
     testImplementation 'com.fasterxml.jackson.core:jackson-databind:2.17.1'
     testImplementation 'com.fasterxml.jackson.core:jackson-annotations:2.17.1'
     testImplementation 'com.fasterxml.jackson.core:jackson-core:2.17.1'

src/main/java/io/kestra/plugin/minio/Copy.java

@@ -37,7 +37,7 @@
     }
 )
 @Schema(
-    title = "Copy a file between S3 service."
+    title = "Copy a file between buckets."
 )
 public class Copy extends AbstractMinioObject implements RunnableTask<Copy.Output> {
 

src/main/java/io/kestra/plugin/minio/CreateBucket.java

@@ -36,7 +36,7 @@
 public class CreateBucket extends AbstractMinioObject implements RunnableTask<CreateBucket.Output> {
 
     @Schema(
-        title = "Specifies whether you want S3 Object Lock to be enabled for the new bucket."
+        title = "Specifies whether you want Object Lock to be enabled for the new bucket."
     )
     @PluginProperty
     private Boolean objectLockEnabledForBucket;

src/main/java/io/kestra/plugin/minio/Delete.java

@@ -30,7 +30,7 @@
     }
 )
 @Schema(
-    title = "Delete a file from S3 service."
+    title = "Delete a file from a bucket."
 )
 public class Delete extends AbstractMinioObject implements RunnableTask<Delete.Output> {
 
@@ -41,7 +41,7 @@ public class Delete extends AbstractMinioObject implements RunnableTask<Delete.O
     private String key;
 
     @Schema(
-        title = "Indicates whether S3 Object Lock should bypass Governance-mode restrictions to process this operation."
+        title = "Indicates whether Object Lock should bypass Governance-mode restrictions to process this operation."
     )
     @PluginProperty
     private Boolean bypassGovernanceRetention;

src/main/java/io/kestra/plugin/minio/DeleteList.java

@@ -43,7 +43,7 @@
     }
 )
 @Schema(
-    title = "Delete a list of keys on a S3 service."
+    title = "Delete a list of keys on a bucket."
 )
 public class DeleteList extends AbstractMinioObject implements RunnableTask<DeleteList.Output> {
 
@@ -100,7 +100,7 @@ public class DeleteList extends AbstractMinioObject implements RunnableTask<Dele
     @Schema(
         title = "raise an error if the file is not found"
     )
-    @PluginProperty(dynamic = true)
+    @PluginProperty
     @Builder.Default
     private final Boolean errorOnEmpty = false;
 

src/main/java/io/kestra/plugin/minio/Download.java

@@ -40,7 +40,7 @@
     }
 )
 @Schema(
-    title = "Download a file from S3 service."
+    title = "Download a file from a bucket."
 )
 public class Download extends AbstractMinioObject implements RunnableTask<Download.Output> {
 

src/main/java/io/kestra/plugin/minio/Downloads.java

@@ -40,7 +40,7 @@
     }
 )
 @Schema(
-    title = "Downloads multiple files from a S3 service."
+    title = "Downloads multiple files from a bucket."
 )
 public class Downloads extends AbstractMinioObject implements RunnableTask<Downloads.Output> {
 
@@ -63,8 +63,8 @@ public enum Action {
     private String delimiter;
 
     @Schema(
-        title = "Marker is where you want Amazon S3 to start listing from.",
-        description = "Amazon S3 starts listing after this specified key. Marker can be any key in the bucket."
+        title = "Marker is where you want to start listing from.",
+        description = "Start listing after this specified key. Marker can be any key in the bucket."
     )
     @PluginProperty(dynamic = true)
     private String marker;
@@ -170,7 +170,7 @@ public Output run(RunContext runContext) throws Exception {
     public static class Output implements io.kestra.core.models.tasks.Output {
         @JsonInclude
         @Schema(
-            title = "The list of S3 objects."
+            title = "The list of objects."
         )
         private final java.util.List<MinioObject> objects;
 

src/main/java/io/kestra/plugin/minio/List.java

@@ -40,7 +40,7 @@
     }
 )
 @Schema(
-    title = "List keys on a S3 service."
+    title = "List keys on a bucket."
 )
 public class List extends AbstractMinioObject implements RunnableTask<List.Output> {
 
@@ -69,8 +69,8 @@ public enum Filter {
     private String delimiter;
 
     @Schema(
-        title = "Marker is where you want Amazon S3 to start listing from.",
-        description = "Amazon S3 starts listing after this specified key. Marker can be any key in the bucket."
+        title = "Marker is where you want to start listing from.",
+        description = "Start listing after this specified key. Marker can be any key in the bucket."
     )
     @PluginProperty(dynamic = true)
     private String marker;
@@ -203,7 +203,7 @@ private boolean filter(Item object, String regExp) {
     public static class Output implements io.kestra.core.models.tasks.Output {
         @JsonInclude
         @Schema(
-            title = "The list of S3 objects."
+            title = "The list of objects."
         )
         private final java.util.List<MinioObject> objects;
     }

src/main/java/io/kestra/plugin/minio/MinioConnectionInterface.java

@@ -8,19 +8,19 @@
 public interface MinioConnectionInterface {
 
     @Schema(
-        title = "URL to S3 service."
+        title = "URL to the MinIO endpoint."
     )
     @PluginProperty(dynamic = true)
     String getEndpoint();
 
     @Schema(
-        title = "Access Key Id in order to connect to S3 service."
+        title = "Access Key Id for authentication."
     )
     @PluginProperty(dynamic = true)
     String getAccessKeyId();
 
     @Schema(
-        title = "Secret Key Id in order to connect to S3 service."
+        title = "Secret Key Id for authentication."
     )
     @PluginProperty(dynamic = true)
     String getSecretKeyId();

src/main/java/io/kestra/plugin/minio/Trigger.java

@@ -24,8 +24,8 @@
 @Getter
 @NoArgsConstructor
 @Schema(
-    title = "Wait for files on S3 service.",
-    description = "This trigger will poll every `interval` s3 service. " +
+    title = "Wait for files on a bucket.",
+    description = "This trigger will list every `interval` a bucket. " +
         "You can search for all files in a bucket or directory in `from` or you can filter the files with a `regExp`. " +
         "The detection is atomic, internally we do a list and interact only with files listed.\n" +
         "Once a file is detected, we download the file on internal storage and processed with declared `action` " +
@@ -34,10 +34,10 @@
 @Plugin(
     examples = {
         @Example(
-            title = "Wait for a list of files on a s3 service and iterate through the files.",
+            title = "Wait for a list of files on a bucket and iterate through the files.",
             full = true,
             code = {
-                "id: s3-listen",
+                "id: minio-listen",
                 "namespace: company.team",
                 "",
                 "tasks:",
@@ -64,10 +64,10 @@
             }
         ),
         @Example(
-            title = "Wait for a list of files on a s3 service and iterate through the files. Delete files manually after processing to prevent infinite triggering.",
+            title = "Wait for a list of files on a bucket and iterate through the files. Delete files manually after processing to prevent infinite triggering.",
             full = true,
             code = {
-                "id: s3-listen",
+                "id: minio-listen",
                 "namespace: company.team",
                 "",
                 "tasks:",

src/main/java/io/kestra/plugin/minio/Upload.java

@@ -50,7 +50,7 @@
     }
 )
 @Schema(
-    title = "Upload a file to S3."
+    title = "Upload a file to a bucket."
 )
 public class Upload extends AbstractMinioObject implements RunnableTask<Upload.Output> {
 
@@ -76,7 +76,7 @@ public class Upload extends AbstractMinioObject implements RunnableTask<Upload.O
     private String contentType;
 
     @Schema(
-        title = "A map of metadata to store with the object in S3."
+        title = "A map of metadata to store with the object."
     )
     @PluginProperty(dynamic = true)
     private Map<String, String> metadata;