Optimize SaturatingLong #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement various optimizations to reduce the number of instructions and branches: - Outline exception throws to relieve i-cache pressure - Fold common comparisons in plus() to go from 94 instructions and 32 branches down to 51 and 5 (94/32 -> 51/5) - Similarly simplify times()/div()/rem()/unaryMinus()/toString() - Make isInfinite() branchless - Inline operators that simply delegate to another operator - Inline trivial work that delegates to intrinsics (sign) Instructions were counted on a Pixel 8 (aarch64) using Android 15.
JakeWharton
reviewed
Jan 2, 2025
| @@ -153,3 +160,8 @@ internal value class SaturatingLong(val rawValue: Long) { | |||
| internal inline val Long.saturated get() = SaturatingLong(this) | |||
| internal inline val POSITIVE_INFINITY get() = SaturatingLong(Long.MAX_VALUE) | |||
| internal inline val NEGATIVE_INFINITY get() = SaturatingLong(Long.MIN_VALUE) | |||
|
|
|||
| // TODO: Supply a ProGuard rule to keep this method so it's not inlined | |||
There was a problem hiding this comment.
Easiest is to put them in src/jvmMain/resources/META-INF/proguard/alchemist.pro. This should cover both JVM usage (e.g., Compose Desktop) and Android.
|
This is awesome. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement various optimizations to reduce the number of instructions and branches:
Instructions were counted on a Pixel 8 (aarch64) using Android 15.