Add rpc duration logging for chat_local #6108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaxim
reviewed
Mar 2, 2017
| // perfLog logs function call durations in ms. | ||
| // example usage: defer h.perfLog("MyFunc", time.Now()) | ||
| func (h *chatLocalHandler) perfLog(name string, start time.Time) { | ||
| h.G().Log.Debug("ChatPerf %s: %d", name, time.Since(start)/time.Millisecond) |
There was a problem hiding this comment.
Is there any use case where start would not be time.Now?
There was a problem hiding this comment.
it has to be a parameter so that the defer works.
but yes, the internal ones inside NewConversationLocal don't use time.Now().
There was a problem hiding this comment.
Could do something like:
func (h *chatLocalHandler) perfLog(name string) func() {
start := time.Now()
return func() {
h.G().Log.Debug("ChatPerf %s: %d", name, time.Since(start)/time.Millisecond)
}
}
...
defer h.perfLog("mike")()Up to you though.
There was a problem hiding this comment.
But yeah, doesn't make sense if this is used inside the function too.
There was a problem hiding this comment.
Yeah, that's similar to the Trace func we have, but sometimes we forget to call the function it returns :) ...i.e. compiler doesn't complain about h.perfLog("mike").
mmaxim
approved these changes
Mar 2, 2017
|
What's the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.