Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update eslint to 9 #40

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

timofei-iatsenko
Copy link
Contributor

@timofei-iatsenko timofei-iatsenko commented Nov 21, 2024

Eslint 8 is no longer supported. This PR migrates to the eslint 9 + flat config.

It also adds 3 new configs to the setup:

  • react.configs.flat.recommended
  • react.configs.flat["jsx-runtime"]
  • eslintConfigPrettier (this one disables all rules already covered by prettier, receommended by prettier team)

@timofei-iatsenko
Copy link
Contributor Author

@garronej

@garronej garronej merged commit ef759e3 into keycloakify:main Nov 22, 2024
1 check passed
@garronej
Copy link
Collaborator

Hello @timofei-iatsenko,

Thank you for that!

@@ -2,6 +2,7 @@ import { i18nBuilder } from "keycloakify/login";
import type { ThemeName } from "../kc.gen";

/** @see: https://docs.keycloakify.dev/i18n */
// eslint-disable-next-line @typescript-eslint/no-unused-vars
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn eslint be trying preventing us from doing anything smart.

garronej added a commit that referenced this pull request Nov 22, 2024
garronej added a commit that referenced this pull request Nov 22, 2024
@timofei-iatsenko timofei-iatsenko deleted the chore/eslint-9 branch November 22, 2024 07:12
OualidGardsign added a commit to garDsign/keycloakify-starter that referenced this pull request Jan 15, 2025
* Eject login page

* Demo Tailwind

* Update keycloakify and remove account theme boilerplate

* Update keycloakify

* update keycloakify

* Update to Keycloakify v10

* Update Keycloakify

* Update README.md

* Update keycloakify

* update keycloakify

* Update keycloakify

* Update keycloakify

* update readme

* add engines

* Update keycloakify

* Update to Keycloakify 11

* update prettierignore

* Update keycloakify

* Update keycloakify

* Update keycloakify

* update keycloakify

* Update keycloakify

* update keycloakify

* Update keycloakify and fmt

* Update keycloakify

* Update keycloakify

* keycloakify#40

* Update keycloakify

* Update documentation links

* Update keycloakify

* Update keycloakify

* Update keycloakify

* Bump keycloakify

* Update keycloakify

* Update keycloakify

* Update keycloakify

* Update keycloakify

* Update keycloakify

* Update keycloakify

* Update keycloakify

* Update keycloakify

* Updat keycloakify

* Update package.json

---------

Co-authored-by: Joseph Garrone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants