-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update eslint to 9 #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timofei-iatsenko
force-pushed
the
chore/eslint-9
branch
from
November 21, 2024 13:52
50096c6
to
9f74b95
Compare
Hello @timofei-iatsenko, Thank you for that! |
garronej
reviewed
Nov 22, 2024
@@ -2,6 +2,7 @@ import { i18nBuilder } from "keycloakify/login"; | |||
import type { ThemeName } from "../kc.gen"; | |||
|
|||
/** @see: https://docs.keycloakify.dev/i18n */ | |||
// eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn eslint be trying preventing us from doing anything smart.
OualidGardsign
added a commit
to garDsign/keycloakify-starter
that referenced
this pull request
Jan 15, 2025
* Eject login page * Demo Tailwind * Update keycloakify and remove account theme boilerplate * Update keycloakify * update keycloakify * Update to Keycloakify v10 * Update Keycloakify * Update README.md * Update keycloakify * update keycloakify * Update keycloakify * Update keycloakify * update readme * add engines * Update keycloakify * Update to Keycloakify 11 * update prettierignore * Update keycloakify * Update keycloakify * Update keycloakify * update keycloakify * Update keycloakify * update keycloakify * Update keycloakify and fmt * Update keycloakify * Update keycloakify * keycloakify#40 * Update keycloakify * Update documentation links * Update keycloakify * Update keycloakify * Update keycloakify * Bump keycloakify * Update keycloakify * Update keycloakify * Update keycloakify * Update keycloakify * Update keycloakify * Update keycloakify * Update keycloakify * Update keycloakify * Updat keycloakify * Update package.json --------- Co-authored-by: Joseph Garrone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eslint 8 is no longer supported. This PR migrates to the eslint 9 + flat config.
It also adds 3 new configs to the setup: