[cs_pinyin] CS-Pinyin keyboard initial public version #64

mcdurdin · 2017-07-27T05:12:49Z

This is a public version of the CS-Pinyin keyboard (from keyman-keyboards-internal). It contains all the files necessary to build the keyboard and the DLLs that go with it.

~~I will be checking the build agent to ensure that it can build the DLLs.~~ We have checked in builds of the DLLs so that we don't introduce a Windows dependency for building the keyboards repo.

DavidLRowe

README.md: Replace "DESCRIPTION" with description.

HISTORY.md: "Template" in first line should be changed to project name (or deleted).

\source\images*.bmp: Names of some files contain upper case letters. Not sure if this is a potential problem or not.

\source\docs: Are "About the Four Corner Method.pdf" and "The Four Corner Index Lookup Method.pdf" distinct documents?

\source\docs: "Using Simplified Chinese.pdf" contains references to Keyman version 6, and to tavultesoft.com

\source\docs: Are "Using Simplified Chinese.pdf" and "Using the CS-Pinyin IMX.pdf" distinct documents?

Running build.cmd failed until a build folder was created manually.

Installing with Keyman Configuration seems to add "Uninstall Simplified Chinese" shortcut to start menu.

mcdurdin · 2017-08-07T07:17:00Z

.cfx file has the wrong name (should match keyboard base name).
Even when .cfx is named correctly, the keyboard isn't working.

LornaSIL · 2017-09-29T19:59:07Z

When I try to build I get this error:

cs_pinyin.kps: Warning: Warning: File ...\keyboards\cs_pinyin\source\..\build\KeymnIMX.dll does not exist.
cs_pinyin.kps: Warning: Warning: File ...\keyboards\cs_pinyin\source\..\build\imxconfig.exe does not exist.
cs_pinyin.kps: Warning: Warning: File ...\keyboards\cs_pinyin\source\..\build\KeymnIMX.x64.dll does not exist.

I think the .kps is looking in the wrong place for the .dlls?

A lot of the documentation still talks about Tavultesoft and Keyman 6.

mcdurdin · 2017-09-30T03:17:56Z

I've just added the work-in-progress label to clarify that this keyboard is not yet really ready for review. The content was put online to give another developer access to the source for their own purposes and I will continue to prepare this for release as time permits.

Do you think we should close the PR and reopen it later? Or just leave it open as a hint to yours truly that something should be done about it?

LornaSIL · 2017-10-02T19:27:51Z

The work in progress label is helpful.

…o cs-pinyin

MakaraSok · 2017-10-26T07:03:29Z

Missing files in the package have been copied from the legacy .kmp and put in the /build folder. Those files are: imxconfig.exe, KeymnIMX.dll and KeymnIMX.x64.dll.

The tweaks fix the errors, but the keyboard doesn't function well yet. It needs further investigation.

Also, the content of the README.md and CS-Pinyin ReadMe.html have been updated.

mcdurdin · 2017-10-26T09:13:43Z

Note: those files are supposed to be built during the keyboard build process but the build script needs updating to make it work with the new build.sh infrastructure.

…

On Thu, 26 Oct 2017 at 2:03 pm, Makara ***@***.***> wrote: Missing files in the package have been copied from the legacy .kmp and put in the /build folder. Those files are: imxconfig.exe, KeymnIMX.dll and KeymnIMX.x64.dll. The tweaks fix the errors, but the keyboard doesn't function well yet. It needs further investigation. Also, the content of the README.md and CS-Pinyin ReadMe.html have been updated. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#64 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AESjvc2h0L0jMWY56Klvp3rl9jraPeEGks5swC7BgaJpZM4OkzN2> .

DavidLRowe · 2020-04-17T17:25:39Z

@mcdurdin Two years ago you wrote: "Do you think we should close the PR and reopen it later? Or just leave it open as a hint to yours truly that something should be done about it?" How well has that hint been working? ;)

LornaSIL · 2024-06-19T18:12:36Z

ask me again in two years. Currently my to do list is probably about 5 years long and getting longer.

Four years ago on June 18, 2020 you asked us to ask you in 2 years. Is there any likelihood this will be done @mcdurdin?

rc-swag · 2024-06-19T22:28:38Z

Four years ago on June 18, 2020 you asked us to ask you in 2 years. Is there any likelihood this will be done @mcdurdin?

Well, I have fixed a problem with it when you open more than one application at a time. However, the main issue the first point of my TODO above is the main sticking point it needs to build the dll. I think it will be done as we get the single repo keyboards?

mcdurdin · 2024-07-02T10:07:54Z

@rc-swag and I will be discussing cs-pinyin this week with the aim of getting something published, even if it is not optimal. (A full IME/picker rework is on the future roadmap)

Build the relevant .dll and .exe files, include them in source/ so that we don't need to rebuild them every time, and reorganize files ready for Keyman 17.

All the global variables should be thread local. This probably needs more review. The `EnumThreadWindows` call in `FindGlyph` should be eliminated, as we can just look at the `hwnd` variable.

mcdurdin · 2024-07-05T02:38:19Z

Is there any likelihood this will be done @mcdurdin?

It's nearly done now... we should be able to get it over the line soon I hope!

DavidLRowe · 2024-07-05T17:28:42Z

I get it, @mcdurdin : You're holding out for a few more weeks to make it a seven-year PR!

LornaSIL · 2024-07-05T18:23:30Z

Could you delete keyboard_info?
In LICENSE.md please extend the copyright date 2017-2024 - actually it should be 2003-2024.
In HISTORY.md are you interested in bumping the date to 2024 and our goal could be a release on July 27 :)
README.md could have copyright and version removed.
Could you change the encoding for .kmn from ANSI to UTF-8?
- Please remove copyright year in .kmn
In the .kps, Details you could remove the version and tick "Package version follows keyboard version"
- Please remove copyright date or extend it to 2024.
CS-Pinyin Install.bmp needs updating to remove the "(c) 2011 Tavultesoft"
welcome.htm could have the copyright information removed
CS-Pinyin ReadMe.html it would be wise to rename this to readme.htm since it has spaces and casing. Then it needs updating in the .kps.
- This file could also have the copyright information removed

~~- Since this is exactly the same name as the keyboard in legacy, there should not be a deprecation, the folder in legacy should be deleted.~~

LornaSIL · 2024-07-05T19:20:45Z

Since this is exactly the same name as the keyboard in legacy, there should not be a deprecation, the folder in legacy should be deleted.

Scratch that. It has a different folder name. So, the .kps file needs to be updated to deprecate the legacy\c\cs-pinyin keyboard.

LornaSIL · 2024-07-05T19:29:32Z

I've done minor testing of the keyboard in Word 2019. It seems to be working, even in Github comments (特命). I'm not sure how else to test.

I wondered if you were wanting to address this issue? #219

Also, all the documentation (pdfs) are outdated, but I suspect that is out of scope for this current fix.

This change has several fixes. 1) Multiple monitor support. If the primary monitor is not the left most monitor then 'screencordinates' can be negative. The IMX windows now displays on all monitors. The IMX window can now moved (click drag) on all monitors. 2) Remove the EnumThreadWindows as the windowhandle was already known. 3) UpdateWindow is has correct calculation (sign was wrong) and also incorrectly set -ve x values to zero

The imxconfig.cpp and KeymnIMX.cpp files had a different location defined for accessing the configuration keys. This resulted in the configuration being updated but not read correctly by the IMX dll. Ideally the read and write functions should also be harmonised. However, refactoring this code should soon become a yak shave.

mcdurdin · 2024-07-30T23:28:38Z

I wondered if you were wanting to address this issue? #219

This should definitely be fixed in a separate PR!

Also, all the documentation (pdfs) are outdated, but I suspect that is out of scope for this current fix.

Yes, I think we'll aim to update documentation separately as well.

For remaining items, @rc-swag are you able to cover those? (What else are we waiting on for publishing this?)

rc-swag · 2024-07-31T00:23:28Z

For remaining items, @rc-swag are you able to cover those? (What else are we waiting on for publishing this?)

Yes I can address those items @LornaSIL raised. The last two commits address the functional issues with the window ids, multi-monitor support and finally the registry settings.

rc-swag · 2024-07-31T10:46:54Z

Bring the copyright and format of the keyboard upto the current Keyman Developer 17 layout.

rc-swag · 2024-07-31T13:51:03Z

@LornaSIL and @mcdurdin I believe I have addressed those remaining items.

LornaSIL · 2024-07-31T15:44:06Z

Just one more thing:

The .kps file needs to be updated to deprecate the legacy\c\cs-pinyin keyboard.

That is in Details / Related Packages

Click on Add and type in cs-pinyin for the Related package ID. Select Deprecated. Apparently it finds the path by itself.

rc-swag · 2024-07-31T23:17:53Z

Ok added the related package

LornaSIL

LGTM!!!!

CS-Pinyin initial version

03c38ac

mcdurdin added the keyboard label Jul 27, 2017

mcdurdin requested review from LornaSIL and DavidLRowe July 27, 2017 05:13

Create build folder if missing in build script

53f0557

DavidLRowe self-assigned this Aug 1, 2017

DavidLRowe reviewed Aug 1, 2017

View reviewed changes

mcdurdin added keyboard and removed keyboard labels Aug 21, 2017

MakaraSok added 3 commits August 25, 2017 14:02

rename .cfx file

143ed2e

Merge branch 'master' into cs-pinyin

2cc8cfa

move cs-pinyin to the new layout

a5821e6

mcdurdin added the work-in-progress label Sep 30, 2017

Merge branch 'master' into cs-pinyin

a90775d

Merge branch 'master' into cs-pinyin

0d872de

DavidLRowe added ready-to-merge and removed ready-to-merge labels Oct 25, 2017

MakaraSok added 3 commits October 26, 2017 13:07

Merge branch 'master' into cs-pinyin

b92839b

Merge branch 'cs-pinyin' of https://github.com/mcdurdin/keyboards int…

9a69d97

…o cs-pinyin

fix compile errors and update some metadata

19e43d0

MakaraSok changed the title ~~CS-Pinyin keyboard initial public version~~ [cs_pinyin] CS-Pinyin keyboard initial public version Feb 13, 2018

mcdurdin added the new label Feb 25, 2018

mcdurdin added 5 commits July 4, 2024 17:17

chore: add build.bat script and reorganize for Keyman 17

5c98a65

Build the relevant .dll and .exe files, include them in source/ so that we don't need to rebuild them every time, and reorganize files ready for Keyman 17.

Merge branch 'master' into cs-pinyin

290864c

chore: restore validate.inc.sh

3212b7e

chore(cs_pinyin): cleanup README and remove old files

73b694b

chore(cs_pinyin): make global variables thread_local

f77f6d0

All the global variables should be thread local. This probably needs more review. The `EnumThreadWindows` call in `FindGlyph` should be eliminated, as we can just look at the `hwnd` variable.

Merge branch 'master' into cs-pinyin

854ac90

rc-swag added 2 commits July 15, 2024 16:56

rc-swag added 2 commits July 31, 2024 23:43

chore: Update copyright and file names and locations

ee2ab11

Bring the copyright and format of the keyboard upto the current Keyman Developer 17 layout.

fix: remove style block per review comment

8a9bf74

rc-swag mentioned this pull request Jul 31, 2024

chore: CS Pinyin documentation (pdfs) require updating #3006

Open

chore: add related legacey cs-pinyin

11e1c07

LornaSIL approved these changes Aug 1, 2024

View reviewed changes

DavidLRowe merged commit baa25b6 into keymanapp:master Aug 1, 2024
2 checks passed

mcdurdin deleted the cs-pinyin branch September 17, 2024 02:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cs_pinyin] CS-Pinyin keyboard initial public version #64

[cs_pinyin] CS-Pinyin keyboard initial public version #64

mcdurdin commented Jul 27, 2017 •

edited

Loading

DavidLRowe left a comment

mcdurdin commented Aug 7, 2017

LornaSIL commented Sep 29, 2017

mcdurdin commented Sep 30, 2017

LornaSIL commented Oct 2, 2017

MakaraSok commented Oct 26, 2017

mcdurdin commented Oct 26, 2017 via email

DavidLRowe commented Apr 17, 2020

LornaSIL commented Jun 19, 2024

rc-swag commented Jun 19, 2024

mcdurdin commented Jul 2, 2024

mcdurdin commented Jul 5, 2024

DavidLRowe commented Jul 5, 2024

LornaSIL commented Jul 5, 2024 •

edited

Loading

LornaSIL commented Jul 5, 2024

LornaSIL commented Jul 5, 2024

mcdurdin commented Jul 30, 2024

rc-swag commented Jul 31, 2024

rc-swag commented Jul 31, 2024 •

edited

Loading

rc-swag commented Jul 31, 2024

LornaSIL commented Jul 31, 2024

rc-swag commented Jul 31, 2024

LornaSIL left a comment

[cs_pinyin] CS-Pinyin keyboard initial public version #64

[cs_pinyin] CS-Pinyin keyboard initial public version #64

Conversation

mcdurdin commented Jul 27, 2017 • edited Loading

DavidLRowe left a comment

Choose a reason for hiding this comment

mcdurdin commented Aug 7, 2017

LornaSIL commented Sep 29, 2017

mcdurdin commented Sep 30, 2017

LornaSIL commented Oct 2, 2017

MakaraSok commented Oct 26, 2017

mcdurdin commented Oct 26, 2017 via email

DavidLRowe commented Apr 17, 2020

LornaSIL commented Jun 19, 2024

rc-swag commented Jun 19, 2024

mcdurdin commented Jul 2, 2024

mcdurdin commented Jul 5, 2024

DavidLRowe commented Jul 5, 2024

LornaSIL commented Jul 5, 2024 • edited Loading

LornaSIL commented Jul 5, 2024

LornaSIL commented Jul 5, 2024

mcdurdin commented Jul 30, 2024

rc-swag commented Jul 31, 2024

rc-swag commented Jul 31, 2024 • edited Loading

rc-swag commented Jul 31, 2024

LornaSIL commented Jul 31, 2024

rc-swag commented Jul 31, 2024

LornaSIL left a comment

Choose a reason for hiding this comment

mcdurdin commented Jul 27, 2017 •

edited

Loading

LornaSIL commented Jul 5, 2024 •

edited

Loading

rc-swag commented Jul 31, 2024 •

edited

Loading