Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial submission of Chadian Arabic predictive keyboard #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffheath-sil
Copy link
Contributor

Based on 3 source word lists

@keyman-server
Copy link

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

@DavidLRowe
Copy link
Contributor

Generally looks pretty good, just a few changes (plus some suggestions):

Delete source/wordlist.tsv since this file (created by the New Project wizard) is not used

In the LICENSE.md file, could you change "SIL" to "SIL International" in the copyright statement (and any other copyright statements you keep, but see below)

In the README.md, could you change the description, even if it's just: "Lexical model for Chadian Arabic".

sil.shu-latn.chadian_arabic.model_info: change description as for README.md

Suggestions:

We now require only the LICENSE.md file to have a copyright statement with the date and the name of the copyright holder. Any other copyright statement can have only the name, BUT other copyright statements are optional. (This reduces the number of files that need to change for the next version.) I'd suggest that you:

  • Remove the copyright line from README.md (and likewise remove the version number, since that's in HISTORY.md)
  • Remove the copyright line from readme.htm
  • Remove the copyright line from welcome.htm

One other comment: I was a little surprised to see no frequency count with Paratext word list. Is that intentional?

@DavidLRowe
Copy link
Contributor

@jeffheath-sil No pressure, but just want to make sure you don't need anything from me in order to proceed.

@DavidLRowe
Copy link
Contributor

@jeffheath-sil Just checking on status.

@DavidLRowe
Copy link
Contributor

@jeffheath-sil Checking on status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants